59 lines · cpp
1//===----------------------------------------------------------------------===//2//3// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.4// See https://llvm.org/LICENSE.txt for license information.5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception6//7//===----------------------------------------------------------------------===//8 9#include "DispatchOnceNonstaticCheck.h"10#include "clang/AST/ASTContext.h"11#include "clang/AST/Decl.h"12#include "clang/AST/DeclObjC.h"13#include "clang/ASTMatchers/ASTMatchFinder.h"14#include "clang/ASTMatchers/ASTMatchers.h"15#include "clang/Basic/Diagnostic.h"16 17using namespace clang::ast_matchers;18 19namespace clang::tidy::darwin {20 21void DispatchOnceNonstaticCheck::registerMatchers(MatchFinder *Finder) {22 // Find variables without static or global storage. VarDecls do not include23 // struct/class members, which are FieldDecls.24 Finder->addMatcher(25 varDecl(hasLocalStorage(), hasType(asString("dispatch_once_t")))26 .bind("non-static-var"),27 this);28 29 // Members of structs or classes might be okay, if the use is at static or30 // global scope. These will be ignored for now. But ObjC ivars can be31 // flagged immediately, since they cannot be static.32 Finder->addMatcher(33 objcIvarDecl(hasType(asString("dispatch_once_t"))).bind("ivar"), this);34}35 36void DispatchOnceNonstaticCheck::check(const MatchFinder::MatchResult &Result) {37 if (const auto *VD = Result.Nodes.getNodeAs<VarDecl>("non-static-var")) {38 if (const auto *PD = dyn_cast<ParmVarDecl>(VD)) {39 // Catch function/method parameters, as any dispatch_once_t should be40 // passed by pointer instead.41 diag(PD->getTypeSpecStartLoc(),42 "dispatch_once_t variables must have static or global storage "43 "duration; function parameters should be pointer references");44 } else {45 diag(VD->getTypeSpecStartLoc(), "dispatch_once_t variables must have "46 "static or global storage duration")47 << FixItHint::CreateInsertion(VD->getTypeSpecStartLoc(), "static ");48 }49 }50 51 if (const auto *D = Result.Nodes.getNodeAs<ObjCIvarDecl>("ivar")) {52 diag(D->getTypeSpecStartLoc(),53 "dispatch_once_t variables must have static or global storage "54 "duration and cannot be Objective-C instance variables");55 }56}57 58} // namespace clang::tidy::darwin59